search

karask / python-bitcoin-utils

Library to interact with the Bitcoin network. Ideal for low-level learning and experimenting.
MIT License
262 stars 99 forks source link

#70 soution proposal #71

Closed guptamukund22 closed 2 months ago

guptamukund22 commented 2 months ago

As mentioned in issue #70 , I have organized the constants in appropriate sections to enhance code manageability and clarity. Expected Benefits: Improved Readability: New and existing developers can more easily understand the structure and logic of the code, which enhances the onboarding process. Ease of Maintenance: Updates to constant values or the addition of new constants can be managed more efficiently when they are well organized. Considerations:

Impact on Other Modules: Changes in constants.py may affect other files that import these constants. All affected files have been reviewed to ensure compatibility, but I encourage reviewers to double-check and discuss potential impacts that might have been overlooked.

PS: I believe that making these changes now will significantly benefit developers in the future, even though they require careful implementation to avoid disrupting existing functionalities.

karask commented 2 months ago

Hi @guptamukund22

The comment meant to just group them in sections with a comment. Just as you did but without adding any new structure because that breaks the code wherever these constants are used. New structure also makes it more verbose which I'd rather not have, for now.

guptamukund22 commented 2 months ago

I have made the appropriate changes, kindly have a look.