search

karask / python-bitcoin-utils

Library to interact with the Bitcoin network. Ideal for low-level learning and experimenting.
MIT License
262 stars 99 forks source link

TODO : _op_push_data #86

Closed guptamukund22 closed 2 months ago

guptamukund22 commented 2 months ago

In class Script of file script.py , method _op_push_data is now modified and handles parameter data according to the its type. TODO completed.

karask commented 2 months ago

Hi @guptamukund22

I was not sure about this (that is why the 'maybe'.. and now that I am thinking of it more we'd better leave it to explicitly accept str (hex).

Can you revert the changes and just remove the TODO comments and I will accept.

Sorry you had to spend time on this.

guptamukund22 commented 2 months ago

@karask No issues! I have made the required changes to merge.