Added to bitcoin-rpc lib option to ignore invalid ssl cert

karask / python-bitcoin-utils

Library to interact with the Bitcoin network. Ideal for low-level learning and experimenting.

MIT License

262 stars 99 forks source link

Closed iamhardikat11 closed 1 month ago

iamhardikat11 commented 2 months ago

[ ] needed to access remotely without cert (for other validators from clients)
[ ] Followed for reference https://github.com/jgarzik/python-bitcoinrpc/pull/50
[ ] But not in a lib release yet,
[ ] So added a config.ini option to optionally ignore cert so that it works when calling btcd remotely

iamhardikat11 commented 2 months ago

Hi @karask Can you check this PR? Or provide any feedback on any changes that need to be made.

karask commented 2 months ago

Hi @iamhardikat11

Please remove ConfigParser and config.ini and just pass the an ignore_ssl_cert flag as an optional parameter, like host and port. Default value True.

I know TODO mentioned a config.ini but now that I am thinking it again I believe it just unnecessarily complicates things.