search

karask / python-bitcoin-utils

Library to interact with the Bitcoin network. Ideal for low-level learning and experimenting.
MIT License
262 stars 99 forks source link

TODO: check if i_to_b32 is needed or not #93

Closed iamhardikat11 closed 1 month ago

iamhardikat11 commented 2 months ago

In the utils.py that was minor change done to remove i_to_b32 and I changed the i_to_b function to remove redundancy. All Tests Passed.

karask commented 2 months ago

The current TODO file does not contain this todo. The i_to_b32 is mostly used so I want to keep it (and call this in the code).

The i_to_h should stay even if it is in comments.

Your update to i_to_b is fine but it shouldn't used for b32 cases. In case byte_length is None you unnecessarily have a print statement.