search

karastojko / mailio

mailio is a cross platform C++ library for MIME format and SMTP, POP3, IMAP protocols. It is based on the standard C++ 17 and Boost library.
Other
381 stars 102 forks source link

Replace format(string, bool) with format(string, message_format_options). Add add_bcc_headers opt #151

Closed LhKipp closed 8 months ago

LhKipp commented 9 months ago

Hi Tomislav,

opening this PR as a follow up to #150. Let me know what you think 👍🏻

LhKipp commented 9 months ago

FYI: The following testcases fail for me locally:

  1. format_html_att
  2. format_msg_att
  3. format_attachment_utf8

(They also fail on the master branch. So they are unrelated to this PR)

(Edit: Fixed formatting to make clear, that all 3 testcases fail locally on this branch and on the master branch for me)

LhKipp commented 8 months ago

Hi @karastojko,

sorry for my late reply, I haven't noticed, you've left a thumbs up.

I fixed the formatting of my 2nd comment, to make clear that all 3 testcases fail locally on this branch and on the master branch for me. I have no intentions of fixing the testcases, as they seem unrelated to my PR for me (please correct me if I am wrong).

Could you please let me know whether you consider merging the PR (as is or changed)?

karastojko commented 8 months ago

Hey @LhKipp , thanks for the PR. I am taking a look now, and I will run these public tests and some private ones.

karastojko commented 8 months ago

Thanks for the PR, this is the right way to enhance message formatting.

karastojko commented 8 months ago

FYI: The following testcases fail for me locally:

1. format_html_att
2. format_msg_att
3. format_attachment_utf8

(They also fail on the master branch. So they are unrelated to this PR)

(Edit: Fixed formatting to make clear, that all 3 testcases fail locally on this branch and on the master branch for me)

The tests require two files aleph0.png and cv.txt for some cases. They should be installed when building with the make install (Unix) or from the solution when building the install project (Msvc/Windows). I will clarify that in the instructions, thanks for pointing this out.