karasusan / OpenVDBForUnity

Unity plugins for OpenVDB

MIT License

258 stars 39 forks source link

Material adjustments ... #1

Closed davoodkharmanzar closed 5 years ago

davoodkharmanzar commented 5 years ago

thanks for this incredible plugin ...

is it possible to import and playing animated VDBs [or sequential]?? also is it possible to controlling animated VDBs by Timeline?? does this plugin be able to cast shadows to other objects??

and i can't to adjust their material directly!! seems that have to duplicate material properties to new and apply adjusted new material to VDB container ... capture

karasusan commented 5 years ago

I'm glad you like it.

Of course, I want to implement animated VDB and Timeline. I already have planned these features.

I implemented that generate the default material as subasset. That is why the material is locked. I am sure of your complaints. I will consider another specification.

karasusan commented 5 years ago

Make Issue #4.

karasusan commented 5 years ago

Please check this PR.

https://github.com/karasusan/OpenVDBForUnity/issues/8

karasusan commented 5 years ago

Merged #8

davoodkharmanzar commented 5 years ago

i got these errors!! capture

karasusan commented 5 years ago

Mm... Maybe C# version is lower.

Check it. https://docs.unity3d.com/Manual/ScriptingRuntimeUpgrade.html

Should I support lower C# version? This is not difficult for me.

davoodkharmanzar commented 5 years ago

i think lower is better ... for better compatibility :]

davoodkharmanzar commented 5 years ago

also i got these new errors after switching to .net 4.x and trying to extract VDB texture and material: capture

karasusan commented 5 years ago

Fixed #9

karasusan commented 5 years ago

also i got these new errors after switching to .net 4.x and trying to extract VDB texture and material:

Oh, This problem specific to the Windows platform. I'll check it on Windows.

davoodkharmanzar commented 5 years ago

seems that #10 is incompatible with .net 3.5!!

karasusan commented 5 years ago

10 is a different matter than #9.

davoodkharmanzar commented 5 years ago

so ... we need to implement this var projectPath = Path.GetDirectoryName(Application.dataPath) + "/"; for #9 too ;]

karasusan commented 5 years ago

Merged #9.

These PRs has no conflicts. Now, running unittest for this plugin automatically on Unity Cloud Build.

davoodkharmanzar commented 5 years ago

well done 👍

karasusan commented 5 years ago

Merged #10.