search

karate / fuego-fighters

A top-down arcade game inspired by Aero Fighters, written in Python and Pygame
4 stars 7 forks source link

Not your problem, but still #14

Closed Zedwill96 closed 3 years ago

Zedwill96 commented 3 years ago

Fatal error in CLI.py when exiting game, not your problem but if you could help me figured out why, that be awesome.

karate commented 3 years ago

You're referring to #13, which is not going to be merged,

I can't troubleshoot this. You've made so many changes that I can't even make it run in the first place.

Zedwill96 commented 3 years ago

ok that's fine, either way, to run it with prython just run CLI.py with python

karate commented 3 years ago

I haven't installed pygame globally, only inside the virtual environment, with pip install -r requirements.txt. If I try to run python CLI.py I get the following error:

$ python CLI.py
Traceback (most recent call last):
  File "/.../fuego-fighters/CLI.py", line 1, in <module>
    from __init__ import main
  File "/.../fuego-fighters/__init__.py", line 4, in <module>
    import pygame
ModuleNotFoundError: No module named 'pygame'

Maybe it's not your fault after all.

karate commented 3 years ago

I tried the latest commit in #13 and I don't see any errors.

Zedwill96 commented 3 years ago

have you updated to the latest version of pygame in your venv? When i first tried to package it i got that error, i have to install the latest pygame to venv, by the way i use pycharm

karate commented 3 years ago

I think the problem was that you had tracked the venv directory. As i said, I tried the latest commit from PR #13 and it works. There is no fatal error in CLI.py when exiting the game. This is a non-reproducible bug.

Zedwill96 commented 3 years ago

No i reproduced it serveral time, it's with the packaged files, something to do with the --noconsole option during packaging, i know how to work around it, thanks man