karate / fuego-fighters

A top-down arcade game inspired by Aero Fighters, written in Python and Pygame
4 stars 7 forks source link

remove specific version for pygame #4

Closed ckauf closed 5 years ago

ckauf commented 5 years ago

Hey,

I tried to get your game running but got the error "freetype-config: Command not found"

Collecting pygame==1.9.3 (from -r ./requirements.txt (line 1))
  Using cached https://files.pythonhosted.org/packages/61/06/3c25051549c252cc6fde01c8aeae90b96831370884504fe428a623316def/pygame-1.9.3.tar.gz
    Complete output from command python setup.py egg_info:

    WARNING, No "Setup" File Exists, Running "config.py"
    Using UNIX configuration...

    /bin/sh: freetype-config: Command not found
    /bin/sh: freetype-config: Command not found
    /bin/sh: freetype-config: Command not found

    Hunting dependencies...
    WARNING: "freetype-config" failed!
    SDL     : found 1.2.15
    FONT    : not found
    IMAGE   : not found
    MIXER   : not found
    PNG     : found
    JPEG    : found
    SCRAP   : found
    PORTMIDI: not found
    PORTTIME: not found
    FREETYPE: not found
    Missing dependencies

This pull requests removes the specific version for pygame. I tested it and it looks to work as expected with pygame v1.9.4.

karate commented 5 years ago

Thanks for the PR @ckauf.

I'd rather not remove the version requirement of pygame, as this may break the app when the available major version change (eg. a backwards incompatible pygame verion 2.0)

ckauf commented 5 years ago

No, I did only try this on ArchLinux. I have freetype2 2.9.1-1 installed. Here is the bug report for ArchLinux: https://bugs.archlinux.org/task/58447

pip did install v1.9.4 (pygame-1.9.4-cp37-cp37m-manylinux1_x86_64.whl) and does it when I use ~= 1.9 in requirements.txt too

I think this is the bug report for pygame that introduced the change: https://github.com/pygame/pygame/issues/437

karate commented 5 years ago

I have freetype2 2.9.1-1 and I'm testing it on Arch as well.

When you remove the version from requirements.txt, it installs pygame-1.9 and it works? If you use pygame~=1.9 it doesn't do the same?

ckauf commented 5 years ago

To sum it up: With the current requirements.txt pip tries to install pygame-1.9.3 (see error message in first post) Without the specific version set for pygame it installs 1.9.4 for me (which works fine) Specifying pygame~=1.9 does also install 1.9.4

karate commented 5 years ago

So, can you change your commit to pygame~=1.9, just to make sure that the application won't break on a future update of pygame?