Closed rc2201 closed 8 months ago
I'd like to work on this!
@Jasmine-maryj sure go ahead, here is the Hacktoberfest process we follow: https://github.com/karatelabs/karate/wiki/Hacktoberfest
some more requests to consider: https://stackoverflow.com/q/77664133/143475
Thanks Peter, I think these would be helpful additions
@ptrthomas this is open for a while. I would like to work on this.
@codehackerr sure, please proceed with a PR
@ptrthomas
Adding Skipped Count: Whenever a scenario is skipped
in ScenarioRuntime
, skippedCount
variable is incremented on FeatureResult
. This is later used in the feature-summary
report.
Change to Totals calculation on a Feature:
Scenario Total = Scenario Success + Scenario Failed
.Scenario Total = Scenario Success + Scenario Failed + Scenario Skipped
.Scenario Run Total = Scenario Success + Scenario Failed
Results
class and add skippedScenarios
to this. Will add a totals row in feature-summary.html
Kindly review and suggest any modifications. If approach is okay, I can push a PR soon. Thanks!
I am getting a 403 on branch push.
Permission to karatelabs/karate.git denied to codehackerr
.
I am able to push to other repos, so authentication is okay.
Is there any access grants required ?
@codehackerr please refer to the typical PR process: https://github.com/karatelabs/karate/blob/master/.github/CONTRIBUTING.md
I am also waiting for the Karate summary report enhancement, for a while. Good to see progress on this issue. When will this be released?
Will the sticky headers or frames be included?
On Tue, Jan 16, 2024, 2:56 PM shassankani @.***> wrote:
I am also waiting for the Karate summary report enhancement, for a while. Good to see progress on this issue. When will this be released?
— Reply to this email directly, view it on GitHub https://github.com/karatelabs/karate/issues/2340#issuecomment-1894578771, or unsubscribe https://github.com/notifications/unsubscribe-auth/A6CKQUIDDMAQOPFHXOKTUSLYO3ZQPAVCNFSM6AAAAAAZEAILT6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJUGU3TQNZXGE . You are receiving this because you commented.Message ID: @.***>
@Mike-c-Jackson From what I understand, not in the scope of this issue. Could you link me to existing feature requests/issues or create one with the details?
This was mentioned in the linked post that @ptrthomas added on Dev 14th. That is the 4th post in this chain
this has been merged to develop
I tested the changes. changes for pass % and total are working fine. But i was not able to verify skipped scenario count. Here is the use case which was tried and mentioned-
Even though it should not matter, i have tried with abortedStepsShouldPass value as true and false.
@codehackerr what was the criteria to count a scenario as skipped?
@rc2201 - please if this is is not resolved soon, we will be undo-ing all related changes, no other team has requested this. I don't think karate.abort()
should be used extensively. anyone is welcome to open a new discussion to discuss if any fundamental changes need to be made to karate.
trying to put conditional logic in tests is an anti-pattern, but I'm open to exploring if testing of complex business-rules can be made easier - but I'd like to understand the context first
all: to be clear why we are considering to undo all related changes is because we have a report of breaking changes to existing users of karate, refer: https://github.com/karatelabs/karate/pull/2477#issuecomment-1923380270
especially as this is a cosmetic request and not something we see many teams ask for - we'll play it safe and undo these changes. anyone is welcome to submit a PR to fix this and get confirmation that there are no breaking changes to existing users - but I don't consider this a priority
@ptrthomas i send an email to you with context around this enhancement request.
changes have been reverted, closing as wontfix
We are using karate.abort() extensively in our project to control the execution of scenarios depending upon the test data pre-requirement, environment limitations etc. Along with this,our runner executes multiple feature files.
Below enhancement to karate summary report would greatly improve our experience with the reporting-
Attaching the screenshot for refrence.
Hopefully, other karate users will also find these features useful as well.