search

karatelabs / karate

Test Automation Made Simple
https://karatelabs.github.io/karate
MIT License
8.14k stars 1.94k forks source link

match != fails with two integers #917

Closed ewexlerr closed 4 years ago

ewexlerr commented 5 years ago

A scenario consisting solely of:

Then match 456 != 123

Fails with:

testingEquals.feature:8 - path: $, actual: 456, NOT expected: 123, reason: equal

Using 0.9.4. Using assert instead of match works as expected, but I don't see why match != wouldn't work here based on its section of the documentation.

ptrthomas commented 5 years ago

@ewexlerr personally I don't consider this a priority at all. adding hacktober and help wanted tags

corp-ray commented 5 years ago

I will volunteer to look into this as part of hacktober fest. Fix might just be a documentation thing. match seems to say explicitly that parentheses are required for it to work.

TamannaBhasin27 commented 5 years ago

I have fixed the issue and raised PR - https://github.com/intuit/karate/pull/918

corp-ray commented 5 years ago

I am glad the issue was fixed. @ptrthomas Anything else that is easy to get into that I could work on for Hacktober fest? I've never used Karate and don't understand nearly all of the issues/tasks. Any tests that need writing or buggy tests that need fixing? I couldn't install Karate on first try because some tests were failing (both when I ran mvn clean install -P pre-release and then again when I ran mvn install -P fatjar) -- I could investigate why that is the case? (Also, why do tests run on install? Is that desirable?)

ptrthomas commented 5 years ago

@corp-ray have you read the instructions here: https://github.com/intuit/karate/wiki/Developer-Guide - if those are incomplete, you can start by suggesting changes to that !

ptrthomas commented 4 years ago

released 0.9.5