karawin / Ka-Radio32

esp32 version of Ka-Radio (https://github.com/karawin/Ka-Radio) by jp Cocatrix
523 stars 155 forks source link

esp_log.h : No such file or directory #59

Closed shurikby closed 5 years ago

shurikby commented 5 years ago

Hi! When I try to compile version 1.4 and 1.5 i have this error: /main/gpio.c:12:22: fatal error: esp_log.h : No such file or directory Maybe you just forgot to add this file to the git repo?

h1aji commented 5 years ago

I had same issue and there are couple of typos. First in main/gpio.c line 12 #include "esp_log.h " space needs to be removed Second in main/CLickButtons.c L should be lower case

@karawin can you please fix this?

karawin commented 5 years ago

First in main/gpio.c line 12 #include "esp_log.h " space needs to be removed Why not. no problem

Second in main/CLickButtons.c L should be lower case Why?????

karawin commented 5 years ago

Under mingw32 on windows10 no problem. Is it a problem under linux?

shurikby commented 5 years ago

Yes, I have this problem under linux. But it seems that esp_log.h just not presented in repo.

h1aji commented 5 years ago

Under mingw32 on windows10 no problem. Is it a problem under linux?

Linux is case-sensitive, so things like this will cause the error.

Yes, I have this problem under linux. But it seems that esp_log.h just not presented in repo. It does exist, there is a space symbol that causes this error.

h1aji commented 5 years ago

@karawin Created two pull requests, please merge them. Should fix error on Linux platform. Thanks

karawin commented 5 years ago

esp_log.h is an esp-idf include https://github.com/espressif/esp-idf/blob/master/components/log/include/esp_log.h I will remove the blanc char.

Uppercase are valid here.

Source has evolved. I don't merge. Done in next delivery,Thanks.

h1aji commented 5 years ago

@karawin can you please carefully look at this name "CLickButtons.h".

Especially second character. Capital L This is causing error in Linux

h1aji commented 5 years ago

CC build/main/ClickButtons.o /home/hmurad/esp/Ka-Radio32/main/ClickButtons.c:16:26: fatal error: ClickButtons.h: No such file or directory compilation terminated. make[1]: [/home/hmurad/esp/esp-idf/make/component_wrapper.mk:286: ClickButtons.o] Error 1 make: [/home/hmurad/esp/esp-idf/make/project.mk:505: component-main-build] Error 2

karawin commented 5 years ago

Yes, it was a L but i corrected it after the pre delivery. Thanks

bazooka07 commented 5 years ago

I have Ubuntu 18.04 LTS and I have the same problem. Today, for compiling, I make

cd main/include
mv CLickButtons.h ClickButtons.h
cd ../../
make menuconfig
# update "Serial flasher config /  default serial port" to /dev/ttyUSB0
make
make flash

and it's works fine ! Please, don't use uppercase letters in filenames for the main folder. To enhance some word, use underscore "_"

mv ClickButtons.h click_buttons.h

Don't use "<br/>" in README.md file. Markdown isn't HTML.

karawin commented 5 years ago

The case sensitive is not a problem under linux. Some typos detected and corrected, that's all. Update to the last commit.

PS I don't know so much MarkDown. How can i make a new line?

bazooka07 commented 5 years ago

It' not a problem of typo but file system. Case sensitive in file names is very important under Linux. More than Windows.

Replace <br /> by two white spaces at the end of line. If you have two subsequent <br />, simply use an empty line. Enumerated lists require an empty line before and after. No break line is required. Simply start each line with "- ". For image, loot at examples there : https://guides.github.com/features/mastering-markdown/

I push a request for updating README.md. Enjoy it !

karawin commented 5 years ago

Thanks for the MarkDown tips.

"It' not a problem of typo but file system. Case sensitive in file names is very important under Linux. More than Windows."

I don't agree. I work with linux since the 0.9 kernel and since 1993 and helped on some howto documents;, so i am sure that the file system is not a problem even with upper and lower cases mixed. Simply it is not tolerant to mistakes. That's all..

bazooka07 commented 5 years ago

Download the Zip archive of this repo and search in for main/include/ClickButtons.h file Not found ! In place, we have main/include/CLickButtons.h file We have the same trouble by git clone ...

karawin commented 5 years ago

OK, github on windows don't care about uppercase. Corrected now, sorry.