Release tags missing on repo

hiteshjasani commented 4 years ago

Did someone delete all the git tags from the repository on purpose? I have 1.1.0 installed on my laptop but am unable to find that version (or any version for that matter) on nimble. The impact on me is that I'm getting a build failure in a Github Action while it's trying to install karax.

on laptop:

karax  [#b99a543, #5e9709b, 1.1.0, 0.2.0, #cd3e7cc]

Searching nimble:

nimble search karax --ver

karax:                                                                          
  url:         https://github.com/pragmagic/karax (git)                         
  tags:        browser, DOM, virtual-DOM, UI                                    
  description: Karax is a framework for developing single page applications in N
im.                                                                             
  license:     MIT                                                              
  website:     https://github.com/pragmagic/karax
  versions:    (No versions tagged in the remote repository)

If I put a dependency on a specific commit of karax, then I get this error on my laptop:

$ nimble test -y --verbose

...

   Checking for karax@#f6bda9a                                                  
 Installing karax@#f6bda9a                                                      
    Reading official package list                                               
Downloading https://github.com/pragmagic/karax using git                        
       Info /private/var/folders/f4/gzyr8mcn5yv0jvdv5l47zygr0000gn/T/nimble_4896
3/githubcom_pragmagickarax_#f6bda9a/karax_48963.nims(5, 22) Warning: imported an
d not used: 'strutils' [UnusedImport]                                           
   Warning: Package 'karax' has an incorrect structure. It should contain a sing
le directory hierarchy for source files, named 'karax', but file 'scrollapp_simp
le.nim' is in a directory named 'experiments' instead. This will be an error in 
the future.                                                                     
      Hint: If 'experiments' contains source files for building 'karax', rename 
it to 'karax'. Otherwise, prevent its installation by adding `skipDirs = @["expe
riments"]` to the .nimble file.                                                 
       Info /private/var/folders/f4/gzyr8mcn5yv0jvdv5l47zygr0000gn/T/nimble_4896
3/githubcom_pragmagickarax_#f6bda9a/karax_48963.nims(5, 22) Warning: imported an
d not used: 'strutils' [UnusedImport]                                           
  Verifying dependencies for karax@#f6bda9a                                     
 Installing karax@#f6bda9a                                                      
     Error: No binaries built, did you specify a valid binary name?

If I remove the specific git commit hash, then it installs karax fine on my laptop. But that could be because it already had version 1.1.0 installed from before. With or without the git commit hash, karax fails to install on the Github Action build server.

dom96 commented 4 years ago

I wouldn't be surprised if there never were any tags. I don't even see any commits which explicitly state "Version 1.1.0" in the Nimble file's history: https://github.com/pragmagic/karax/commits/master/karax.nimble.

@Araq can we tag the latest version at least?

hiteshjasani commented 4 years ago

It's still worth it to tag this repository so people can see the release in nimble but my issue with karax failing to install is no longer a problem. The resolution was to create separate nimble files for the server and client js pages in a web application.

Araq commented 4 years ago

I'll tag it really soon now, I promise!

Araq commented 4 years ago

Sorry this took so long. Now done.

karaxnim / karax

Release tags missing on repo #130