karaxnim / karax

Karax. Single page applications for Nim.
MIT License
1.07k stars 90 forks source link

unified patch for namespaced tags #261

Closed scattergory closed 11 months ago

scattergory commented 1 year ago

svg and mathML need to be written with namespaces specified by the xmls parameter.

https://developer.mozilla.org/en-US/docs/Web/SVG/Namespaces_Crash_Course

This patch defines mathML and svg element sets for future reference, and the needingNamespace elements that have to be declared with a namespace, as well as default namespaces for SVG and mathML.

This should set up math and svg elements to work just like regular html in the karax DSL. The global variable settings can be overridden without modifying the package if the user desires.

geotre commented 11 months ago

@scattergory what is the status of this PR? The tests are currently failing, please see this comment as it is likely the same error

geotre commented 11 months ago

Closing as SVG support was just added in #271 . Apologies for not following up with you sooner @scattergory