nesquena
commented
10 years ago Kara, :+1: nice work. A few notes after checking out the code:
- SearchImage should be called
SearchImageActivity(all activity should suffix with activity) - Ton of duplicate networking code here and here. This is a code smell. Consider how to merge these into a single method (see feedback guide)
- You should use
android:entriesas explained here to populate your spinners and clean up the code. - Architectural point, but consider refactoring this and all other query filter stuff into an object that keeps this complexity out of the controller (activity). See feedback guide for details.
- Nice job passing the query filters back to the original activity. As you pointed out though you didn't pass them back to settings which makes for a poor user experience.
Good submission overall. Also, here's provided a more detailed Project 2 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you could improve your submission.
Let us know if you have any other thoughts or questions about this assignment. The next assignment (Twitter Client) will be especially important since it introduces the majority of the remaining pieces necessary to build a fully functional API client with complex feeds of data and user creation.
Hey Nathan,
So sorry this is late. It took a bit longer than I had expected. Here it is!
One thing that I didn't get a chance to implement was the ability to pass the current settings back to the settings page so that when you go there, the current options are still selected.
Thanks so much for being understanding of my travel schedule this week.
Best, Kara
/cc @nesquena @timothy1ee