search

karbassi / netatmo

A node.js module to hook into the netatmo API.
MIT License
58 stars 46 forks source link

Added getThermostatsData #14

Closed marcuspocus closed 8 years ago

marcuspocus commented 8 years ago

Also added some minimal jsdoc comment and marked deprecated methods with @deprecated

karbassi commented 8 years ago

the JSDoc comments are most welcome. Keep the 2 spaces since it's project standard.

I'll merge it in once the spacing is reverted back.

marcuspocus commented 8 years ago

Looking good now.

karbassi commented 8 years ago

Line 366 should be:

this.emit('get-thermostatsdata', err, devices);
marcuspocus commented 8 years ago

Done fixing... Are you OK with it? It's working great on my homebridge-netatmo setup atm...

homebridge-netatmo didn't have netatmo-thermostatssupport, and i needed the getThermostatsData in this netatmo lib for implementing it...

karbassi commented 8 years ago

Looks great! Thanks for the PR!