search

karbassi / netatmo

A node.js module to hook into the netatmo API.
MIT License
57 stars 46 forks source link

Expose access_token #39

Closed ilblog closed 5 years ago

ilblog commented 6 years ago

Can be handy

ilblog commented 6 years ago

Well can you change it as repo owner? I do not know howvto do it technilaly.

But it is fine as it is. It just returns undefined and it is responibility of client to check it.

IL

On 16 Mar 2018, at 21:37, Ali Karbassi notifications@github.com wrote:

@karbassi requested changes on this pull request.

In netatmo.js:

@@ -135,6 +135,15 @@ netatmo.prototype.authenticate = function (args, callback) { return this; };

+/**

    • @returns access_token
  • */ +netatmo.prototype.getAccessToken = function () {
  • return access_token Should check to see if there is an access_token first and then return it. Otherwise should return false or an error.

Thoughts @ilblog?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.