search

kardeiz / pallet

81 stars 2 forks source link

Upgrade depedencies (tantivy, sled), clean up Cargo.toml #4

Closed lberezy closed 3 years ago

lberezy commented 3 years ago

This PR upgrades the versions of tantivy and sled to their latest respective versions, addressing the issue where the current state of the crate is unable to build. This also removes the need to patch the sled crate as those changes have been upstreamed.

I've also upgrade and moved the tempfile dependency to a dev-dependency as it's only used in an example.

There were a few minor breaking changes to both tantivy and sled. I'm not 100% familiar with these crates so I have only done work to get the example to build and run, so not sure about any subtle bugs I may have introduced. My main concern is with how IDs are now generated from a TransactionalTree, required to not hang inside of a transaction context.

lberezy commented 3 years ago

As an aside, I would recommend a full cargo fmt --all across the project to ease further contributions.

kardeiz commented 3 years ago

@lberezy Thanks, this looks great!

Thanks for pointing out the issue with generating IDs. I haven't been following the development of sled (or tantivy) that closely recently, but it looks like this is now fixed by allowing TransactionalTree to generate IDs (see https://github.com/spacejam/sled/pull/1146). I'll merge your PR, make this change myself, than release

I think I'd cargo fmtted everything, but I will be sure to check in my .rustfmt.toml when I bump the version and release. Thanks!

kardeiz commented 3 years ago

@lberezy Oh, nevermind, I see you fixed it so the TransactionalTree generates the IDs. Great!