kardia-as / zigpy-zboss

GNU General Public License v3.0
36 stars 4 forks source link

Write unit tests #7

Closed DamKast closed 4 weeks ago

DamKast commented 1 year ago

Write unit tests for the zigpy-zboss code.

Hedda commented 3 months ago

Any updates on your work to add some ZBOSS radio unit tests same/similar to unit tests in the other radio libraries for zigpy?

puddly's reply to @e3c6a08b1f15492310b7e2912cc3552b in https://github.com/home-assistant/core/pull/114828 indicate this is currently a showstopper.

"Merging support for an untested package would introduce an enormous maintenance burden, as we would not be able to update zigpy without also fixing zigpy-zboss and testing it by hand."

Please see the tests directory for bellows, zigpy-znp, zigpy-deconz, and zigpy-espzb radio libraries and add minimum of tests:

PS: When add tests suggest also checking Home Assistant's "Development Checklist" to make sure checking all those boxes too: