search

kardiachain / go-kardia

Golang implementation of KardiaChain Decentralize Network
https://kardiachain.io
GNU Lesser General Public License v3.0
33 stars 18 forks source link

Hardcoded Private Key #111

Closed sihoang closed 3 years ago

sihoang commented 3 years ago

I was wondering why the private key is hardcoded in the main config https://github.com/kardiachain/go-kardia/blob/master/cmd/cfg/kai_config.yaml#L19

 P2P:
    PrivateKey: 8843ebcb1021b00ae9a644db6617f9c6d870e5fd53624cefe374c1d2d710fd06
    ListenAddress: tcp://0.0.0.0:3000
    MaxPeers: 25
lewtran commented 3 years ago

It's a private key that map with the address in genesis file for local development. We will update the proper config. Thank you for your contribution

lewtran commented 3 years ago

@sihoang please check the PR and close this issue

lewtran commented 3 years ago

Closed due to no response