Fix max_download_threads in cluster mode

karel-brinda / Phylign

Alignment against all pre-2019 bacteria on laptops within a few hours (former MOF-Search)

http://brinda.eu/mof

Other

25 stars 4 forks source link

Fix max_download_threads in cluster mode #227

Closed leoisl closed 9 months ago

leoisl commented 1 year ago

max_download_threads argument is ignored - we can download as much as we want;

Great if it worked for you. But we should be careful not to behave as DOS attackers. Eg NCBI according to some people than temporarily blocks entire IP ranges corresponding to research clusters.

Originally posted by @karel-brinda in https://github.com/karel-brinda/mof-search/issues/226#issuecomment-1589295727

karel-brinda commented 1 year ago

Although not sure what are Zenodo mechanisms for detecting potential DOS attacks....

karel-brinda commented 9 months ago

I'm closing this as this is very highly relevant to #236 and the corresponding PR.

@leoisl Please feel free to reopen it if you don't think so.