karellodewijk / wottactics

Wot tactic planner for CW
MIT License
28 stars 34 forks source link

Suggestion: Add a greyscale filter #10

Open WarWolfen opened 7 years ago

WarWolfen commented 7 years ago

With an additional greyscale filter for the underlying map it would be possible to make the on-top sketches more visible and in the foreground. So the tactics itself get more attention. Sometimes the colors of the underlying maps to disturb the tactical symbols (a bit).

karellodewijk commented 7 years ago

So what form do you think it should take. Should it be applied directly to the background images, a toggle button, a background brightness slider.

NikoGrano commented 7 years ago

If I can tell my opinion, do button to toggle image greyscale. (Simple as possible, nothing can break etc.) It's possible via Javascript, you can modify css or you can write css into code and change class onClick -event.

Anyways CSS code is something like this,

  filter: gray; /* IE6-9 */
  filter: grayscale(1); /* Microsoft Edge and Firefox 35+ */
  -webkit-filter: grayscale(1); /* Google Chrome, Safari 6+ & Opera 15+ */

If you apply background directly to images, it's just waste of bandwidth and disk space. (Also repo size will increase by ~50MB)

Of course slider option might be good as well, but @WarWolfen can answer to that question a lot better than me, because he is using these maps and requesting for this feature.

karellodewijk commented 7 years ago

I can't use css to apply the filter, both the background and everything else are part of the same pixi/webgl context. And since the filter needs to be applied between the background and everything else, it needs to be part of that too.

Anyway it's a technical problem, I can perfectly apply a tint on the background or put a transparent grey/black layer on top of the background, either would work fine.

It's a question of where to put it. Every time I add something like this I add another button to an already very cluttered ui. Tbh the whole ui could use an overhaul, but it's not my strong suit.

WarWolfen commented 7 years ago

I actually think the ui is pretty fine. Only thing with that is that some of the areas are too long downwards and triggering vertical scrollbars (and that is only for the MWO "tab"). That could be fixed by simply add another div with a scrollbar for the controls so that it does not extend max height. Not sure if that is understandable...

image

  1. This area could have its own scrollbar
  2. This could be replaced by a combobox control to save space

As for the greyscale toggle,... Following the logic of the UI, it kind of naturally belongs next to the grid toggle, don't you think?

EDIT: Oh, and I think a slider is not necessary. This is more an on/off thing.