kareltucek / firmware

This is fork of UHK's firmware featuring extended macro engine.
Other
82 stars 9 forks source link

Using a keymapping that uses control leaves control activated #32

Closed VinceG3 closed 5 years ago

VinceG3 commented 5 years ago

Version 8.5.4 of the official firmware fixed an issue where:

However this version of the firmware still exhibits the issue. To reproduce, remap a Base layer key to control anything, it most annoys me in a browser, so try control-w for close tab. Close a tab with the remapped key, then click on any link. It will control-click the link. The held state can be cleared up by tapping Mod.

Note that remapping on the Mod layer doesn't cause the problem, as releasing Mod clears up the held state before you have a chance to click anything. If you remap Mod-W to Control-W, then holding Mod down, tapping W then clicking a button after releasing W but before releasing Mod will Control-Click.

I have reproduced the behavior with Alt and Super Base layer remappings.

Flashing back to latest vanilla fixes it, while flashing back to 8.5.3 brings back the issue.

kareltucek commented 5 years ago

Thanks for report, will look into it soon! Unless you need sticky modifiers, you should be able to disable them entirely by $setStickyModsEnabled 0.

VinceG3 commented 5 years ago

Setting Sticky Mods off got rid of the behavior for me, thanks! Didn't realize that was a feature people actually needed, curious what it's used for.

kareltucek commented 5 years ago

It's for windows's alt+tab, but the proper behaviour should definitely be that of the official 8.5.4 ;-).

kareltucek commented 5 years ago

Fixed. Thanks for the catch!