kareltucek / firmware

This is fork of UHK's firmware featuring extended macro engine.

Other

82 stars 9 forks source link

Implements key-repeat feature for macro #90

Closed soraxas closed 2 years ago

soraxas commented 2 years ago

82

soraxas commented 2 years ago

Hi! Thank you very much for your detailed review and apologise for the delayed response! It had been tough to find some free time to work on this

I've restructured the PR and incorporated a lot of your suggestions into the mix. The logic should also be quite straightforward in the current setup. I've also moved the data to macro-scope and should allow for backward jumps for future development

kareltucek commented 2 years ago

Yep. The control flow is still a bit rough around the edges, but it should work.