karelvuong / st-primer

⚠️ No longer supported ⚠️ - A UI + syntax theme for @SublimeText inspired by GitHub's UI.
https://packagecontrol.io/packages/Theme%20-%20Primer
MIT License
132 stars 18 forks source link

Primer Dark window theme isn't working #19

Closed omgmog closed 9 years ago

omgmog commented 9 years ago

Hello -- first of all thanks for putting together such a nice theme!

I'm having no problems with the light variation of the theme, but the Dark version doesn't seem to work at all.

I installed the package using Wbond's Package Manager, and I've confirmed that the "Primer Dark.sublime-theme" file exists, but it just doesn't want to apply.

I'm using Sublime Text 2, build 2221 on Linux.

Any thoughts?

ghost commented 9 years ago

Hey @omgmog, removing the first "theme": "Primer.sublime-theme" on L3 should fix it. :smile:

omgmog commented 9 years ago

Sorry but it doesn't -- the value is being over-ridden, so that being there and then being set on the following line is fine:

omgmog commented 9 years ago

Okay I've fixed it here.

The problem was caused by the JSON for that theme being malformed. You've got some trailing commas in blocks (due to commenting bits out) that shouldn't be there.

I'll make a pull request to fix if you like

ghost commented 9 years ago

Sure, that'd be helpful, @omgmog!

omgmog commented 9 years ago

:+1: