search

karelzak / mutt-kz

mutt-kz is DEPRECATED in favor of neomutt project.
https://neomutt.org
Other
297 stars 51 forks source link

Sidebar corrupts status line when in pager #32

Open suvayu opened 11 years ago

suvayu commented 11 years ago

Hi,

I have been noticing that having the sidebar turned on seems to corrupt the status line and the screen in general. This happens only in the pager. The following 3 images illustrates the issue.

In the index view, the status line is shown properly. mutt-status-line-index-small

In the pager view the sidebar draws over the status line. mutt-status-line-pager-small

With the sidebar toggled, the status line is drawn properly again in pager view. mutt-status-line-pager-no-sidebar-small

I also notice the sidebar gets corrupted whenever some kind of message is put in by mutt in pager view. For example, I have autoview set for certain binary files like pdf. The display corruption happens when I view a message with a pdf file in pager view and scroll. mutt-screen-corruption-small

Hopefully I have given enough information. :)

Suvayu

suvayu commented 11 years ago

I noticed that upon scrolling (for messages longer than a screen full), the status line gets updated correctly. Hope this helps.

notfoss commented 10 years ago

I also notice the sidebar gets corrupted whenever some kind of message is put in by mutt in pager view. For example, I have autoview set for certain binary files like pdf. The display corruption happens when I view a message with a pdf file in pager view and scroll.

Did you find any solution for this problem?

I am experiencing a similar problem when using elinks to autoview html mails inside the pager. I also experience corruption when scrolling text containing wrapped long lines (displayed using the + character).

It's quite annoying, but redrawing the terminal fixes the problem.

Note: I am not using mutt-kz, but I am using the lunar-linux sidebar patch, and the behaviour is similar.

suvayu commented 10 years ago

Unfortunately no solution yet :(.

notfoss commented 10 years ago

Ah, I see.

@karelzak, are you aware of the issue?

noctuid commented 10 years ago

I've also started having the sidebar get messed up since I started using mutt-kz. I don't remember if I had this problem using the lunar-linux sidebar patch though. Maybe it's more noticeable because of the ugly white bars surrounding the divider. I don't know if that bug is related.

Dabsen commented 10 years ago

Noticed the status bar position issue too. Luckily, it's a one-line fix : curiously the size of the pager status has already been adjusted in the code (that's why it's too short) but the offset on the left is wrong. Here's the patch : line 1801 of pager.c should be move (statusoffset, SidebarWidth); instead of move (statusoffset, 0);

I submitted a pull request. I don't know about the sidebar corruption issue, but I assume this doesn't fix it.

karelzak commented 10 years ago

I have applied Dabsen's patch, please git pull and tests it.

noctuid commented 10 years ago

Alt text

There's even more white for me now (though the status bar is no longer hidden). I haven't seen the statusbar get corrupted recently, so I'm not really sure how often that happens.

Edit: I'm not sure if something else is responsible for that (maybe another change or a change in my config). Here's what it looks like on other mutt with sidebar (not white): Alt text

This is probably a separate issue; the patch fixes the statusbar problem

Dabsen commented 10 years ago

The patch is about the status line (ie the line at the bottom of the screen typically containing folder info in the index view and message info in the pager view) as appearing in pager view. See the original issue, there are some screenshots of the problem.

But do you say it impacts the size of the separator ? strange (doesn't occur for me, and it's in an unrelated part of the code, I believe) The separator is controlled by the sidebar_delim variable, looks like you have sidebar_delim set to something like ' |', you should be able to remove this space via something like set sidebar_delim='|' does that not work ?

On 21 October 2014 17:45, Lit Wakefield notifications@github.com wrote:

I'm not sure if I understand what the patch was supposed to do:

[image: Alt text] https://camo.githubusercontent.com/ccdea6fd43e228278c2762e99610e1fd967a8b8f/687474703a2f2f692e696d6775722e636f6d2f496438757336482e706e67

There's even more white for me now.

— Reply to this email directly or view it on GitHub https://github.com/karelzak/mutt-kz/issues/32#issuecomment-59949036.

noctuid commented 10 years ago

@Dabsen Yeah, I looked at my config and the only reason it's bigger is because I added a space. My problem is with it being white (which is unrelated).

I've made a separate issue like I should have: #82

flatcap commented 8 years ago

@suvayu @notfoss @noctuid @Dabsen There's a new version of Mutt-KZ (1.6.0.1) which contains the latest Sidebar. This should fix all the Sidebar-related drawing issues.