karelzak / mutt-kz

mutt-kz is DEPRECATED in favor of neomutt project.
https://neomutt.org
Other
296 stars 51 forks source link

Sides of Sidebar are White #82

Closed noctuid closed 10 years ago

noctuid commented 10 years ago

This is what the sidebar looks like for me with mutt-kz: Alt text

It looks pretty ugly to me.

This is what it looks like with the lunar-linux sidebar patch: Alt text

Dabsen commented 10 years ago

Ah, I see what your problem is. As things stand, this is controlled by the "sidebar" color setting -- you should be able to change it via color sidebar white black or whatever suits your theme. Does that work ?

noctuid commented 10 years ago

Ah thanks, for the mutt I was using previously it was color sidebar_new (color sidebar gave an error). I've also noticed that the sidebar_shortpath and sidebar_folderindent settings don't exist in mutt-kz (though it it acts as if both were true). Are there different sidebar patches?

Dabsen commented 10 years ago

I don't know, though I assume they probably diverged from a common original patch. It might be a good idea to merge the improvements here... The color settings are inconsistent in mutt-kz : 'sidebar' only controls the delimiter, 'sidebar_new' and 'sidebar_flagged' control the names of folders with new or flagged messages, and the other sidebar lines are controlled by 'normal'. This is not ideal. As for the automatic folderindent, it can be a nuisance -- as for me I just commented out the indenting code.

Le 21/10/2014 à 20:22, Lit Wakefield a écrit :

Ah thanks, for the mutt I was using previously it was color sidebar_new (color sidebar gave an error). I've also noticed that the sidebar_shortpath and sidebar_folderindent settings don't exist in mutt-kz (though it it acts as if both were true). Are there different sidebar patches?


Reply to this email directly or view it on GitHub: https://github.com/karelzak/mutt-kz/issues/82#issuecomment-59973645

noctuid commented 10 years ago

Thanks for that info. sidebar_new and sidebar_flagged and normal have the same behaviour in the normal patch. If by inconsistent, you're talking about the fact that there is no sidebar_normal, then I agree. I don't know if you can actually change the colour of the delimiter in the default patch (there is no sidebar). I think that's an addition here (though I'm not sure why white is default), and the name is misleading.

It looks like there's already an issue about the lack of sidebar_format ( #59 ).

I've ended up just sourcing a script like this to deal with the differences.

mutt_kz=$(mutt -v | grep mutt-kz)
sidebar=$(mutt -v | grep sidebar)

if [ $mutt_kz != "" ]; then
    echo "color sidebar color223 color235"
elif [ $sidebar != "" ];then
    echo "sidebar_shortpath = yes"
    echo "set sidebar_folderindent = no"
fi
Dabsen commented 10 years ago

Yes, I agree, this 'sidebar' option is misleading, and undocumented (at least, I think). I just know about it because I looked at the code when writing my config. Ideally we should have 'sidebar_normal' and 'sidebar_delim', I suppose; but well, it works well enough now.

Le 22/10/2014 à 18:01, Lit Wakefield a écrit :

Thanks for that info. sidebar_new and sidebar_flagged and normal have the same behaviour in the normal patch. If by inconsistent, you're talking about the fact that there is no sidebar_normal, then I agree. I don't know if you can actually change the colour of the delimiter in the default patch (there is no sidebar). I think that's an addition here (though I'm not sure why white is default), and the name is misleading.

It looks like there's already an issue about the lack of sidebar_format ( #59 ).

I've ended up just sourcing a script like this to deal with the differences.

mutt_kz=$(mutt -v | grep mutt-kz)
sidebar=$(mutt -v | grep sidebar)

if [ $mutt_kz != "" ]; then
  echo "color sidebar color223 color235"
elif [ $sidebar != "" ];then
  echo "sidebar_shortpath = yes"
  echo "set sidebar_folderindent = no"
fi

Reply to this email directly or view it on GitHub: https://github.com/karelzak/mutt-kz/issues/82#issuecomment-60109033

karelzak commented 10 years ago

Volunteers? ;-) (for docs updates, or/and implement missing sitebar features?)

karelzak commented 10 years ago

Note that is also

https://github.com/karelzak/mutt-kz/pull/79

I'll merge it probably.

jhutar commented 8 years ago

With mutt-kz-1.6.0.1-1.fc23.x86_64 it is color sidebar_divider black white now. See http://www.neomutt.org/feature/sidebar/#sidebar-colors