Upgrade to Swift 5.0 - Githubissues

kareman / SwiftShell

A Swift framework for shell scripting.

https://kareman.github.io/SwiftShell

MIT License

1.03k stars 87 forks source link

Upgrade to Swift 5.0 #74

Closed Ponyboy47 closed 5 years ago

Ponyboy47 commented 5 years ago

A few things have been deprecated in Swift 5.0 FileManager and Process. This pull request updates SwiftShell to use the new APIs instead of the deprecated ones. No functionality has been changed.

kareman commented 5 years ago

Excellent stuff, thank you very much. I have made some further changes building upon your commits in the https://github.com/kareman/SwiftShell/tree/Swift5 branch. It is currently crashing in travis, but I think that must be because it is using a beta version of Xcode 10.2. The code is working fine on my computer. Could you try it on your computer?

Ponyboy47 commented 5 years ago

👍 I just tested it on my Mac (Mojave 10.14.3 with Xcode 10.2 and Swift 5). Everything built without error and all the tests passed

kareman commented 5 years ago

I just released SwiftShell 5.0.0 with your changes. Thanks again for help.