karenetheridge / JSON-Schema-Modern

Validate data against a schema using a JSON Schema
https://metacpan.org/release/JSON-Schema-Modern/
Other
10 stars 1 forks source link

Failed test 'format-idn-email.json ...' #30

Closed eserte closed 4 years ago

eserte commented 4 years ago

t/additional-tests.t fails on some of my smokers:

#   Failed test 'format-idn-email.json: "validation of an internationalized e-mail addresses" - "an invalid e-mail address"'
#   at t/additional-tests.t line 35.
#          got: 'true'
#     expected: 'false'
# 
# 
# Results using Test::JSON::Schema::Acceptance 0.999
# 
# filename                           pass  fail
# ---------------------------------------------
# anchor.json                           2     0
# format-duration.json                 20     0
# format-idn-email.json                 1     1
# format-ipv6.json                      8     0
# format-uuid.json                     11     0
# future-keywords-draft2019-09.json    10     0
# id.json                               2     0
# invalid-id-and-anchor.json            3     0
# keyword-independence.json           688     0
# not-an-anchor.json                    2     0
# not-an-id.json                        2     0
# recursiveRef.json                    14     0
# ref-and-id.json                       4     0
# ref.json                              4     0
# 
# Looks like you failed 1 test of 773.
t/additional-tests.t ...... 
Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/773 subtests 

Statistical analysis is not able to find possible reasons for the failure.

eserte commented 4 years ago

Finally found a candidate: it seems that it fails if Email::Address::XS is not installed:

****************************************************************
Regression 'qr: Email::Address::XS\s+any\s+(\S+)'
****************************************************************
Name                   Theta          StdErr     T-stat
[0='const']           1.0000          0.0000    18277371054956692.00
[1='eq_1.02']        -0.0000          0.0000      -2.90
[2='eq_1.04']        -0.0000          0.0000      -4.02
[3='eq_missing']             -1.0000          0.0000    -17426789530661450.00

R^2= 1.000, N= 62, K= 4
****************************************************************
karenetheridge commented 4 years ago

thanks. this is actually already fixed in master :)