karfly / learnable-triangulation-pytorch

This repository is an official PyTorch implementation of the paper "Learnable Triangulation of Human Pose" (ICCV 2019, oral). Proposed method archives state-of-the-art results in multi-view 3D human pose estimation!
MIT License
1.1k stars 181 forks source link

AssertionError when setting config.dataset.val.with_damaged_actions=false #125

Closed axhiao closed 3 years ago

axhiao commented 3 years ago

Hi, in the paper you mentioned the validation set has been filtered by removing the scenes 'Greeting-2', 'SittingDown-2', 'Waiting-1'. So I just tried removing theses scenes with config item with_damaged_actions=false. But I got the error:

[train=False, test=True] ./data/human36m/extra/human36m-multiview-labels-GTbboxes.npy has 2107 samples, but './data/pretrained/human36m/human36m_alg_10-04-2019/checkpoints/0060/results/val.pkl' has 2181.

I digged into the codes and found that you got _keypoints_3dpred without filtering. Could you help confirm the issue? Thank you!

shrubb commented 3 years ago

Hi, unfortunately we lost access to Human3.6M so can't test this. I already don't remember how this val.pkl was generated... But I think you can re-generate it yourself with or without damaged actions by just changing the algebraic model's yaml config a little and then re-evaluating it. After that, if things still don't work, you can tweak around view-dataset.py (e.g. load and visualize val.pkl there) to see what breaks.

axhiao commented 3 years ago

@shrubb thank you!