search

kariefury / oppia

Automatically exported from code.google.com/p/oppia
Apache License 2.0
0 stars 0 forks source link

Code review request #558

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Branch name: adventures

Link to the relevant commit(s):
(1) Code: 
https://code.google.com/p/oppia/source/detail?r=6cb6a86bbee9859eb78a7487899d24d0
7dbf5284&name=adventures
(2) Tests: 
https://code.google.com/p/oppia/source/detail?name=adventures&r=5616f7e71ce0e7fd
dc0c30ea3a25b1dbb757e82b

Purpose of code changes on this branch: add domain logic and tests for 
adventures.

When reviewing my code changes, please focus on: comprehensibility, correctness 
and test coverage, mainly for the adventure_domain.py and 
adventure_domain_test.py files.

Note to Marcel/Xinyu: I've asked Jacob to be lead reviewer for these two 
commits, but please feel free to add comments too if you have any -- more eyes 
looking over this code is certainly good, because it'll form part of the core 
logic.

After the review:
- I'm going to work on additional commits to address Marcel's comments in a 
previous review.

Original issue reported on code.google.com by s...@google.com on 30 Jan 2015 at 11:33

GoogleCodeExporter commented 9 years ago 
Marking this as obsolete, since we will not be implementing it.

Original comment by s...@seanlip.org on 2 Mar 2015 at 9:55