Code review request

[GoogleCodeExporter]

Branch name:
splash-fixes

Link to the relevant commit(s):
https://code.google.com/p/oppia/source/detail?r=b7f5573ef7e0b878eff1e4ebe4368592
b1551735&name=splash-fixes

Purpose of code changes on this branch:
Fix a number of margin and spacing issues in the splash page.

When reviewing my code changes, please focus on:
UI

After the review, I'll merge this branch into: develop

Original issue reported on code.google.com by amitdeut...@google.com on 16 Feb 2015 at 5:58

[GoogleCodeExporter]

I made a new commit fixing all the issues, so punting this one back to you :-)

    https://code.google.com/p/oppia/source/detail?r=7d2b84c498cbdd60ab879711d3796d9af56b56ed&name=splash-fixes

PTAL -- if it is all OK, I will merge it into develop.

Thanks!

Original comment by s...@seanlip.org on 16 Feb 2015 at 10:44

[GoogleCodeExporter]

Looks good, I made a few more minor margin changes and darkened the splash 
images so that there's more contrast.

One thing that might be good to do on a separate commit is to fix the filter 
drop downs. Currently, the drop down menu disappears each time you select an 
option; this means that if you want to select 4 categories, you have to open 
the drop down menu 4 separate times. Would it be possible to change it so that 
the drop down menu disappears only if you click outside of the drop down?

Original comment by amitdeut...@google.com on 17 Feb 2015 at 1:47

[GoogleCodeExporter]

Ah, and two more things:

Currently, when you select a category or a language, the page jumps into search 
mode, which is a bit unexpected-- I wonder if it would be better to only go 
into search mode once you start typing?

Second, transitioning to search mode is somewhat jarring, is it easy to do a 
quick fade-out then fade-in?

Original comment by amitdeut...@google.com on 17 Feb 2015 at 1:50

[GoogleCodeExporter]

I'm not sure about the first one in #3. I see selecting a category/language as 
being in the same class of actions as typing a query; both are basically 
mechanisms of specifying a filter for the selection. I think the same rationale 
as for search would apply here: it's weird to change the category at the top of 
the page, and have the changes only appear way below past the sprawling 
territories of the banner image and interstitial, where they are easily missed.

As for the other two, I agree, and will put them on the to-do list.

Original comment by s...@seanlip.org on 17 Feb 2015 at 2:26

[GoogleCodeExporter]

That's fair, it's possible that the fade-out fade-in will make the first one in 
#3 feel more natural. Thanks!

Original comment by amitdeut...@google.com on 17 Feb 2015 at 4:40

[GoogleCodeExporter]

Thanks -- I've added the other issues to my to-do list. Marking this review as 
done for now.

Original comment by s...@seanlip.org on 18 Feb 2015 at 6:21

• Changed state: Done