search

kariefury / oppia

Automatically exported from code.google.com/p/oppia
Apache License 2.0
0 stars 0 forks source link

Code review request #682

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Branch name:
gallery-splash-updates

Link to the relevant commit(s):
https://code.google.com/p/oppia/source/list?name=gallery-splash-updates

Purpose of code changes on this branch:
Add video and make some stylistic changes on the home page.

When reviewing my code changes, please focus on:
Code health, UI
Note: as with the social media chiclets, I'm guessing the video needs to be 
generalized so that our specific video isn't part of the core Oppia codebase. 
I'd actually to program this generalization but I would need your help.

After the review, I'll merge this branch into: develop

Original issue reported on code.google.com by amitdeut...@google.com on 6 Apr 2015 at 4:50

GoogleCodeExporter commented 9 years ago 
Note that I've added the splash video configuration to the admin page, along 
with a few other fixes, in the latest commits.

Original comment by amitdeut...@google.com on 7 Apr 2015 at 3:37

GoogleCodeExporter commented 9 years ago 
Marking the initial review request as done.

(Just FYI, further responses to the code review will show up automatically in 
my inbox, so no need to open new issues after you've made the changes and 
replied.)

Original comment by s...@seanlip.org on 10 Apr 2015 at 1:59