search

karimbahgat / PyCRS

Projection creation, and conversion to misc formats
MIT License
98 stars 20 forks source link

crscode_to_string python 3.5+ compatibility #18

Closed mullenkamp closed 6 years ago

mullenkamp commented 6 years ago

Added decode for bytes object. Addressing issue #17

mullenkamp commented 6 years ago

I noticed that in the pip installation that I recently installed for python 3.6 there are several instances of calls to the bytes function in the pycrs/elements/parameters.py For whatever reason, they are str functions in the git that I forked from this repo...and should stay as such to work. I'm guessing the bytes was the original attempt to correct the python 3.5+ compatibility. I haven't tested all functions, but the ones I have tested with this new fix and the str functions do work.

karimbahgat commented 6 years ago

Thanks a lot! Yes, I don't have too much experience porting to Py3 so that's probably why. Apologies for the long silence, I intend to keep this repo more regularly updated going forward.

mullenkamp commented 6 years ago

Oh good. Welcome back ;) I was worried that this repo had been abandoned. Thanks for updating it.