Judges' feedback

[ghost]

Placeholder issue for judges' feedback.

[railschallenge-judge01]

Rubocop

• there are rubocop failures

Models

• unpermitted.rb is an empty file - don't need that in source
• Responder
  • Commented line: # validates_with UnpermittedParamsValidator, fields: [:emergency_code] should be removed
  • before/after filters can lead to difficult-to-trace code and convoluted workflows
  • An alternative would be to have a business object/PORO that manages he emergency save and dispatch combined workflow
  • The class methods can be moved to scopes
• Emergency
  • Remove commented-out code
  • old code will be in source control and retrievable so not needed as comments
  • Class methods in this file should be moved to scopes
  • calc_full_response - what happens if save fails? There's nothing to capture that case
  • assign_emergency_code - what happens if save fails? There's nothing to capture that case
  • release_responders - what happens if save fails? There's nothing to capture that case

Controllers

• Application Controller
  • respond_to :html, :json - this doesn't need to respond to :html
  • unpermitted? is only called by the emergency controller, so should be moved there
  • unpermitted_param() doesn't appear to be used
  • business logic should move to a dedicated business object, or possibly into a model
• Emergency controller create
  • @emergency.save is not necessary, @emergency.calc_full_response calls save already

[karimmtarek]

@railschallenge-judge01 thanks for the feedback :+1:, I'm working on it :)

[ghost]

Just an FYI, your repo shows an automated score of 110:

• 114 passing assertions (114 points)
• 4 rubocop offenses (-4 points)

4 points probably isn't a huge deal, but if you want to maximize your score you'll want to take a look at those offenses, especially if they are easy to resolve.

The offenses I see when I run rubocop locally are:

Offenses:

app/controllers/application_controller.rb:62:3: C: Metrics/AbcSize: Assignment Branch Condition size for dispatcher is too high. [34.71/15]
  def dispatcher(obj, tbl, severity_hash, type)
  ^^^
app/controllers/application_controller.rb:62:3: C: Metrics/CyclomaticComplexity: Cyclomatic complexity for dispatcher is too high. [8/6]
  def dispatcher(obj, tbl, severity_hash, type)
  ^^^
app/controllers/application_controller.rb:62:3: C: Metrics/PerceivedComplexity: Perceived complexity for dispatcher is too high. [10/7]
  def dispatcher(obj, tbl, severity_hash, type)
  ^^^
app/models/emergency.rb:36:3: C: Metrics/AbcSize: Assignment Branch Condition size for calc_full_response is too high. [17.72/15]
  def calc_full_response
  ^^^

[karimmtarek]

@railschallenge-judge04 Thanks, Rubocop offences should be fixed by now.