search

karimnaaji / vectiler

A vector tile, terrain and city 3d model builder and CLI exporter. Consider using its fully integrated user interface at https://halfmaps.io
https://karim.naaji.fr/projects/vectiler
MIT License
482 stars 71 forks source link

reserved identifier violation #10

Closed elfring closed 8 years ago

elfring commented 8 years ago

I would like to point out that an identifier like "stbi__sse2_available" does eventually not fit to the expected naming convention of the C++ language standard. Would you like to adjust your selection for unique names?

karimnaaji commented 8 years ago

This file is part of the stb libraries, where you could open an issue.

If you want to understand more why this __ is used, you can directly read the design philosophy behind the stb libraries https://github.com/nothings/stb/blob/master/docs/stb_howto.txt#L100_L111. In this case it's a private function used within the scope of the library itself and not exposed through the API.

elfring commented 8 years ago

Will corresponding software improvements be continued with a similar bug report?

karimnaaji commented 8 years ago

Not sure to understand, what do you mean by that?

elfring commented 8 years ago

Would you like to update any bundled software?

karimnaaji commented 8 years ago

Yes I would do so.

Though, I honestly doubt that Sean Barrett would change his naming convention, there's no harm using it since collision are likely not to happen (if used correctly) with the compiler internal naming use.

Thanks