karimra / gribic

gRIBIc is an Openconfig gRIBI Command Line interface
https://gribic.kmrd.dev
10 stars 2 forks source link

bash -c "$(curl -sL https://get-gribic.kmrd.dev)" is broken #17

Open sar772004 opened 1 year ago

sar772004 commented 1 year ago

Install is broken, download url seems to be deduced wrong

Step 51/76 : RUN bash -c "$(curl -sL https://get-gribic.kmrd.dev)" ---> Running in 8b57f8dd0b90 Downloading https://github.com/karimra/gribic/releases/download/null/gribic_ull_linux_x86_64.tar.gz tar: This does not look like a tar archive

gzip: stdin: not in gzip format tar: Child returned status 1 tar: Error is not recoverable: exiting now Failed to install gribic For support, go to https://github.com/karimra/gribic/issues

sar772004 commented 1 year ago

It was only for some time looks like, possibly since the version updated 1 hr ago We can close this, if nothing can be done about it.

karimra commented 1 year ago

Thanks for posting this, I will add a check in the script to validate that the version is not null

sar772004 commented 1 year ago

Is this taken care of ? still failing

Step 52/77 : RUN bash -c "$(curl -sL https://get-gribic.kmrd.dev/)" ---> Running in 64bd5eab3a69 Downloading https://github.com/karimra/gribic/releases/download/null/gribic_ull_linux_x86_64.tar.gz tar: This does not look like a tar archive gzip: stdin: not in gzip format tar: Child returned status 1 tar: Error is not recoverable: exiting now Failed to install gribic For support, go to https://github.com/karimra/gribic/issues The command '/bin/sh -c bash -c "$(curl -sL https://get-gribic.kmrd.dev/)"' returned a non-zero code: 2

sar772004 commented 1 year ago

I think i found the root cause, our org was hitting the download rate-limit from github for the LATEST_URL (which is used to fetch the latest tag) in some instances.

Workaround was to download the file directly from github download directly(staticly) without reading the tag from api