Expressions visitor could not use too much instanceof's

karishma-tirthani / odata4j

Automatically exported from code.google.com/p/odata4j

0 stars 0 forks source link

Expressions visitor could not use too much instanceof's #66

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago

What steps will reproduce the problem?
1. Open org.odata4j.expression.Expression#visit
2. Notice tons of casts and throw at end.

What is the expected output? What do you see instead?

Each expression tree node may implement method visit(Visitor v) and call 
visitExpressionA from it with 'this'.
Current implementation may be unstable if there will be new node added.

Original issue reported on code.google.com by Eugene.P...@gmail.com on 11 Sep 2011 at 10:26

GoogleCodeExporter commented 8 years ago

Original comment by john.spurlock on 29 Sep 2011 at 11:03

Changed state: Started
Added labels: Milestone-Release0.5

GoogleCodeExporter commented 8 years ago

This issue was closed by revision eca2b1423c2b.

Original comment by john.spurlock on 1 Oct 2011 at 9:57

Changed state: Fixed

GoogleCodeExporter commented 8 years ago

Original comment by john.spurlock on 1 Oct 2011 at 11:26

Added labels: Type-Enhancement