karismatic-megafauna / school-working-days-calculator

Calculate the number of school working days from today
MIT License
5 stars 21 forks source link

Style Delete Icon "X" #29

Closed karismatic-megafauna closed 6 years ago

karismatic-megafauna commented 7 years ago

1) Add some sort of Trashcan icon.

2) Have this icon only become visible on hover and don't have the sibling elements move when it does.

3) extra credit, and some sort of animation :)

---- much ❤️ to the person who does this!

ghost commented 7 years ago

I'd like to work on this issue!

lapmid commented 7 years ago

@rriikkuu Are you working on this ??

ghost commented 7 years ago

@lapmid yup

karismatic-megafauna commented 6 years ago

i merged the one from @itsnhduc, but there is a small font-smoothing issue if either @rriikkuu or @lapmid would like to take it :)

itsnhduc commented 6 years ago

Could you elaborate further on the issue?

karismatic-megafauna commented 6 years ago

Humm, i think it was just cause i was connected to a 4k monitor, but the trash cans looked fuzzy, regardless, it's not an issue anymore!

karismatic-megafauna commented 6 years ago

@itsnhduc I actually found something different that I would love your assistance with!

Checkout the this gif...

many_trash_cans

You can reproduce this by adding an exclusion date of the same date...

Any ideas?

itsnhduc commented 6 years ago

I'm aware of this. I previously assumed that there will never be 2 entries with the same item.datesince you're using it as a key for ExcludedDate. If this is to be fixed you're gonna need a new key, either the index of item or a new key attribute. Which one do you prefer?

karismatic-megafauna commented 6 years ago

Yeah, it doesn't make sense to have multiples of the same date...

Ideally it would: 1) Prevent the user from making the exclusion date 2) Put the Reason why in an error banner

I guess doing step 1 would be preferred.

itsnhduc commented 6 years ago

Then this should be a new requirement. Sure I can go ahead and implement this but I think it's better to open this as a new issue and let other folks who haven't completed their Hacktoberfest PRs take care of it.

karismatic-megafauna commented 6 years ago

will do, thanks for contributing @itsnhduc :)