karkaroff / castor

PyTorch deep learning models by the Data Systems Group at the University of Waterloo
http://castor.ai/
Apache License 2.0
0 stars 0 forks source link

Castor compatible CharCNN. #10

Open Ashutosh-Adhikari opened 5 years ago

Ashutosh-Adhikari commented 5 years ago

@karkaroff, @achyudhk do you think we need Castor compatible character level CNN ?

achyudh commented 5 years ago

Pull request #11 addresses this issue. Please take a look at that, and let me know. This issue also leads to a complementary issue #12 that is to be addressed in the future.

Ashutosh-Adhikari commented 5 years ago

Great! So the idea behind opening this issue was to address the same problem identified in #12 . Let us not create redundant issues. Thanks.