search

karlb / wikdict-web

Web front end for WikDict dictionaries
https://www.wikdict.com
MIT License
16 stars 2 forks source link

Run tests using GitHub Actions #11

Closed hartwork closed 3 years ago

hartwork commented 3 years ago

~This sits on top of #4 and #10 (due to semantic dependency) but I can rebase it off of them after the dependencies are merged, if you prefer…~

There is some duplication in here with download_dicts.sh from #6 here. We can adjust that script to only pull a subset, if it's important to you to avoid that duplication, now or later.

Also please note, that in this form the CI will download the same five files off your server for every run. That can be turned to GitHub Actions own caching, where it's then downloading from "itself". I consider that an optimisation personally, unless you consider it a showstopper for the first version to merge, already.

Here's what to except from this pull request (over at my fork, before GitHub picks it up over here): https://github.com/hartwork/wikdict-web/actions/runs/1441308872

PS: Here's an example for the PRs that GitHub Dependabot will create for you in the future: https://github.com/hartwork/jawanndenn/pull/221 .

Looking forward to your feedback :beers:

hartwork commented 3 years ago

@karlb rebased onto latest master just now