search

karlch / vimiv-qt

An image viewer with vim-like keybindings
https://karlch.github.io/vimiv-qt/
GNU General Public License v3.0
177 stars 15 forks source link

In the style config library.selected.fg directive has no effect #840

Closed favinator closed 1 month ago

favinator commented 2 months ago

I noticed that the directive library.selected.fg does nothing. I changed both library.selected.fg and library.selected.bg but it only changed the background. Here is a screenshot of what I'm trying to explain in my poor english...

bugvimiv

karlch commented 2 months ago

Thanks a bunch for catching this and reporting the issue! I can reproduce it and also know where this is coming from. Hoping to push a fix sometime this week :blush:

For the curious: we use a delegate to paint the library within vimiv/gui/library.py, but the delegate does not differ between foreground colors for selected / non-selected rows. Clearly a bug, as it does correctly differ for backgrounds.

Code for font color vs code for bg color.

karlch commented 1 month ago

Should be fixed with #843, thanks again for reporting :blush: