search

karlcow / shoki

shoki (書記) is a secretary in Japanese. This python program is here to help take a text only file of meeting minutes and convert it into structured data. This structured data can then be converted into other formats.
Mozilla Public License 2.0
4 stars 1 forks source link

webcompatwiki (default) doesn't work #24

Closed karlcow closed 5 years ago

karlcow commented 5 years ago 
→ shoki create --location file:///Users/karl/Desktop/webcompat-raw-work-week.txt 
This webcompatwiki format does not exist yet.

Something is happening which prevents the code to not recognize the default output format. This comes from here:

https://github.com/karlcow/shoki/blob/58d71ab992aaed335be8955b426c1c83666802c5/shoki/formatter.py#L75-L90

And probably because it doesn't know how to find the template directory for the formatting.

We need to fix this.

karlcow commented 5 years ago

We need to use MANIFEST.in to declare the files we want to include in our package. For reading the file, it is better to use resource_string so that it will be available in the case of a Python egg or a zip package.

karlcow commented 5 years ago

An example of code.

https://github.com/openPMD/openPMD-viewer/blob/2c7eaaf3ad8cc211612cc28d1712902d5f9943db/opmd_viewer/notebook_starter/openPMD_notebook#L10-L21