search

karldreher / KnowYourPorts

A web application which can be used to lookup TCP/IP ports.
GNU General Public License v3.0
0 stars 5 forks source link

Fix responsiveness and add semantics to html structure #13

Closed guilherme-dev closed 7 years ago

guilherme-dev commented 7 years ago

I've made some basic changes, now the app is responsive across multiple devices screens.

Unfortunately i didn't have much time to work on this, so the layout remains very basic. As soon as I have some free time I'll get in touch, so I could help to improve the visual style.

Hope you like it! Don't hesitate to contact me if you have any issues with these changes.

karldreher commented 7 years ago

@guilherme-dev This looks really great, but is currently conflicting. There's not a great way for me to fix, because your fork is so many revisions back. Can I ask you to reclone and make another pull when you're ready?

guilherme-dev commented 7 years ago

I think that for now I can't do much to help. What I find very strange is that I fetched the upstream repo before commit my changes and before create the pull request, and it was not conflicting. Only after I make the pull request that I was able to see the conflicts. Very likely i made something wrong in the process.

For now it's best to keep your current version, I'll try to keep up with the project and help if possible

karldreher commented 7 years ago

@guilherme-dev No problem, I appreciate your contribution. I think you were a victim of bad timing. I will close your PR for now.