karldreher / KnowYourPorts

A web application which can be used to lookup TCP/IP ports.
GNU General Public License v3.0
0 stars 5 forks source link

some ports with no description will create error 500 #31

Closed karldreher closed 3 years ago

karldreher commented 3 years ago

Example port is 113. The first (see also #32) entry for 113 is "ident" which has "null" description. This should be addressed by the Jinja filtering in input_page.html, however on further investigation may be a data quality issue: \ \ident \tcp \ \113 \

In the example above, the description tag is not opened. I believe this is the source of the issue.

Because this project relies on the IANA registry and don't have the authority to change it, the way I suggest to fix this is by sanitizing it further within ports.py. This was attempted already through the use of empty_text(), but there is not a present solution to address the bug described above.

karldreher commented 3 years ago

fixed in https://github.com/karldreher/KnowYourPorts/commit/bb40d60211ff7b49a226f51885274f8f125fb207

issue will be closed on merge

karldreher commented 3 years ago

Merged in #35