search

karldreher / KnowYourPorts

A web application which can be used to lookup TCP/IP ports.
GNU General Public License v3.0
0 stars 5 forks source link

Multiple port return #32

Open karldreher opened 3 years ago

karldreher commented 3 years ago

A great number of ports have multiple entries in the XML, (e.g. 20) which ultimately are written to the database on import, but there is no facility in the web application for displaying multiple results.

shepherdjay commented 3 years ago

I would like to take a stab at this one.

As an aside looking at some of the issues in the repo have you considered implementing something like flask-sqlalchemy to more easily work with your database models?

karldreher commented 3 years ago

Hi @shepherdjay , thanks for your interest and contributions. I'm flattered by your interest - most of the "issues" are really meant only for me to remember to think about them later, but I'm glad if they pique your interest enough to go out and solve them!

First, the PR #41 you submitted is very interesting. With that said I want to put a pin in it for a couple reasons, the main one being that the CSS is something i want to think about more... the table idea is good but I had a little different vision, which I want to collaborate with you on a bit more. (And, this is my fault for not expressing that more clearly). I'm not merging #41 at this time but will come back to you on it.

Secondarily, I really liked the flask-sqlalchemy idea. I have just started learning about sqlalchemy, and quite honestly sqlite was always a stand-in for a better way... i just hadn't gotten around to it. The suggestion you have in https://github.com/shepherdjay/KnowYourPorts/tree/flask-sqlalchemy-implementation does seem to make this more simple and straightforward... I would be unopposed to a PR for just this part, for starters, to pave the way for more of the frontend work. Please refine the sqlalchemy branch to the degree that you feel comfortable, and focusing on the DB part, and open a new PR for that!

shepherdjay commented 3 years ago

@karldreher Your repo caught my eye as I'm a network engineer professionally - picked up python as a necessity to automation in my field. Not many projects I come across where the knowledge domain is in my wheelhouse.

Would you be opposed to still labeling #41 hacktoberfest-accepted even though there are some UI issues to work out. Don't worry I'm not going anywhere just because October ends.

Will get a new pull request opened for the sql-alchemy after verifying it is cleaned up. I have additional thoughts on the actual implementation of the database but I will open up a new issue to discuss some of those thoughts as I had some questions so as to not clutter this issue with non-related details in the implementation.

karldreher commented 3 years ago

done, thx! All sounds good.