karldreher / KnowYourPorts

A web application which can be used to lookup TCP/IP ports.
GNU General Public License v3.0
0 stars 5 forks source link

Database Persistence and Feed #42

Closed shepherdjay closed 3 years ago

shepherdjay commented 3 years ago

While implementing sqlalchemy I noticed that the original code and my implementation code recreates the entire database from scratch.

Is this desired behavior? I'm assuming the intent is so that a regular restart of the process will result in new data but it also pulls from a local copy so the data is already out of date.

An additional question I had was around using the XML feed instead of the CSV feed? The XML file seems like it makes it difficult to reason about. (I hate working with XML)

shepherdjay commented 3 years ago

I don't mean to disparage XML too much and ElementTree is a fantastic thing to work but it can be a bear sometimes.

karldreher commented 3 years ago

Closing this issue, this is working as intended for the time being.