search

karlfreeman / middleman-deploy

Deploy a middleman built site over rsync, ftp, stfp, or git (e.g. gh-pages on github).
MIT License
553 stars 124 forks source link

Rsync: Configured username ignored #129

Open noniq opened 7 years ago

noniq commented 7 years ago

There’s already a PR fixing this: #127

The bug got introduced in https://github.com/middleman-contrib/middleman-deploy/commit/86f76b2a53b408487eb294c5462c31be0751232a#diff-6d0c130d155d957759feb2f03e0d7f1b: self is necessary here, because the local variable user is shadowing the attribute accessor.

alexec commented 7 years ago

+1

alexec commented 7 years ago

Workaround:

deploy.host          = 'root@host'
vinc commented 7 years ago

Thanks for the workaround @alexec

vizcay commented 6 years ago

I've been hitting my head against the wall the past 20 minutes trying to figure out why I was getting a "Permission denied (public key)" error.. and it was because of this. Please release at least a minor version with this is not a minor bug.