search

karlg100 / homebridge-frigidaire

homebridge Platform plugin for Frigidaire connected appliances
29 stars 10 forks source link

HeaterCooler #31

Open brydoyle opened 3 years ago

brydoyle commented 3 years ago

@karlg100 - I believe the HeaterCooler accessory type was not available in homebridge when this was first created.

Do you know if this type was considered?

I believe it allows for custom mode types and a cool only (removing heat references and lower thermostat bound) modes and also more customization (so that Fan and Eco can be used with their real names), was wondering if any downsides were identified otherwise.

Was going to give a stab at this before the 1.0 to 2.0 breaking changes happened. Also, was thinking a switch for clean air and a sensor for filter cleaning needed.

karlg100 commented 3 years ago

This has been raised a few times before, and haven't looked into this other accessory type.

Right now the Frigidaire lib needs some major retooling, and in the process of doing that.

If you'll like to take a stab at changing the accessory, I'd be happy to have the help!

I do expect the homebridge-Frigidaire plug-in is going to need some tweaking with the changes to the lib plugin.

Please make a new branch for these changes, if you give it a shot. I'll do the same when taking a PR. Well want to keep both going for a while, while things settle out.

I'm also considering other accessories like the dehumidifier, once auto discovery is working again. So any changes will look to make sure that's possible down the road.

karlg100 commented 3 years ago

go for it if you want to give it a try. I think we're done with changes for now.

mjk5025 commented 3 years ago

Full disclosure- I am not a programmer of any sort, but I am trying to learn. Doubt I could be much help with what I am about to suggest.

If we could get the clean air switch changed to HMServiceTypeAirPurifier, and maybe pull in the filter status under HMServiceTypeFilterMaintenance that would be great! https://developer.apple.com/documentation/homekit/hmservice/accessory_service_types

brydoyle commented 3 years ago

Yep. Depends on homebridge support.

In addition - based on some POC I started against Master last night, HeaterCooler should allow for:

"Fan Only" would be an on/off switch within AC service that disables the thermostat setting, shows current temp and ignores COOL/AUTO mode, turns off COOLING status.

Fan speed should show on Home app as a slider with 1,2,3,4 possible modes. (May need to scale to 100 based on a homekit bug / decide on if auto should be 0)

Heat mode should be removed since fan support is above.

Active on/off would power on/off unit and hopefully remember prior state as long and HB is running

COOL and AUTO would map to COOL and ECO. OFF would set active to NO.

Any objections to above handling can be a discussion here.

On Wed, Jun 23, 2021 at 10:33 PM mjk5025 @.***> wrote:

Full disclosure- I am not a programmer of any sort, but I am trying to learn. Doubt I could be much help with what I am about to suggest.

If we could get the clean air switch changed to HMServiceTypeAirPurifier, and maybe pull in the filter status under HMServiceTypeFilterMaintenance that would be great! https://developer.apple.com/documentation/homekit/hmservice/accessory_service_types

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/karlg100/homebridge-frigidaire/issues/31#issuecomment-867286289, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACJVPQWGYXBFRK7SQWTTZM3TUKKOZANCNFSM46TURC4Q .

brydoyle commented 3 years ago

Widget would resemble: https://github.com/mongoose-os-apps/mel-ac-homekit#accessory-design

On Wed, Jun 23, 2021 at 10:42 PM Bryan Doyle @.***> wrote:

Yep. Depends on homebridge support.

In addition - based on some POC I started against Master last night, HeaterCooler should allow for:

"Fan Only" would be an on/off switch within AC service that disables the thermostat setting, shows current temp and ignores COOL/AUTO mode, turns off COOLING status.

Fan speed should show on Home app as a slider with 1,2,3,4 possible modes. (May need to scale to 100 based on a homekit bug / decide on if auto should be 0)

Heat mode should be removed since fan support is above.

Active on/off would power on/off unit and hopefully remember prior state as long and HB is running

COOL and AUTO would map to COOL and ECO. OFF would set active to NO.

Any objections to above handling can be a discussion here.

On Wed, Jun 23, 2021 at 10:33 PM mjk5025 @.***> wrote:

Full disclosure- I am not a programmer of any sort, but I am trying to learn. Doubt I could be much help with what I am about to suggest.

If we could get the clean air switch changed to HMServiceTypeAirPurifier, and maybe pull in the filter status under HMServiceTypeFilterMaintenance that would be great! https://developer.apple.com/documentation/homekit/hmservice/accessory_service_types

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/karlg100/homebridge-frigidaire/issues/31#issuecomment-867286289, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACJVPQWGYXBFRK7SQWTTZM3TUKKOZANCNFSM46TURC4Q .

karlg100 commented 3 years ago

btw, the homebridge API docs have been greatly improved here.

https://developers.homebridge.io/#/characteristic/TargetHeaterCoolerState

karlg100 commented 3 years ago

@mjk5025 - I just added the FilterMaintenance service for the filter status. The Air Purifier doesn't right now support filter status as an optional attribute. new version published.

Unfortunately I'm disappointed to see the native Home.app doesn't show filter maintenance accessory anywhere in the status, but Eve does show it and you can create actions there.