search

karlg100 / homebridge-frigidaire

homebridge Platform plugin for Frigidaire connected appliances
29 stars 10 forks source link

Unnamed device crashes homebridge #4

Closed andrewtelliott closed 6 years ago

andrewtelliott commented 6 years ago

Really just a point for documentation. If your app on the phone is using a default name, it's actually a null value. So a user must set their device's name on the frigidaire app (or a change could probably be made to address this programmatically through iteration AC #1, AC #2, etc)

karlg100 commented 6 years ago

added logic in 1.0.1 to use a default name if one is not specified from the LABEL attribute. Please test after doing a sudo npm update -g homebridge-frigidaire

karlg100 commented 6 years ago

verified fixed with my own devices. only issue that may still be outstanding is if an account has multiple devices, all unnamed.

andrewtelliott commented 6 years ago

@karlg100 Great work. I was so thrilled to see this pop up. Thanks for taking over the project!