search

karlheyes / icecast-kh

KH branch of icecast
GNU General Public License v2.0
298 stars 106 forks source link

The names of the songs is lost amperdans #14

Closed radiopassazh closed 12 years ago

radiopassazh commented 12 years ago

Hello

Sorry for my bad english)

There is a problem - in version 33 song titles amperdans is lost. This is very critical for song titles, in which there are a few artists. In version 29 it works normally

serjkrueger commented 12 years ago

hmm, also noticed this error in win32. But is only on Icecast status page. Metadata with "&" in desktop player displaying normally

radiopassazh commented 12 years ago

Yes, this problem only applies to the status page of the server, the player everything works fine

karlheyes commented 12 years ago

This will be down to the entity checking. quite a few people were doing & and that was not translating but & will be flagged up as invalid, incomplete or missing ;

I'll see if I can work around that

karl.

karlheyes commented 12 years ago

Just committed a fix on master to hopefully deal with those cases. Can you confirm.

karl.

radiopassazh commented 12 years ago

Unfortunately, I can not compile the source code, because I do not know how to do it. Can you compile the executable file for us? Thank you)

karlheyes commented 12 years ago

I have no idea what your platform is nor whether any build I do here will be suitable for you.

karl.

radiopassazh commented 12 years ago

I'm sorry) My platform is Win32 (win server 2008).

Alex

karlheyes commented 12 years ago

try the following

https://github.com/downloads/karlheyes/icecast-kh/icecast-2.3.2-kh33.3_setup.exe

karl.

Allmoz commented 12 years ago

i will do it in linux

Allmoz commented 12 years ago

"&" working

karlheyes commented 12 years ago

thanks Allmoz, basically if there is a chance of an entity there then it will use the routine I had before, if not then skips it

karl.

karlheyes commented 12 years ago

I'll assume this is all working now. The code to make it work is not platform specific and Allmoz also verified it as working. If there is any issue on this then it can be raised again.

karl.